Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove experimental.verification package #2511

Merged
merged 1 commit into from
Apr 29, 2022
Merged

remove experimental.verification package #2511

merged 1 commit into from
Apr 29, 2022

Conversation

ekiwi
Copy link
Contributor

@ekiwi ekiwi commented Apr 29, 2022

All functions inside this package were deprecated
in the 3.5 release, so it is appropriate to remove
them for 3.6

Contributor Checklist

  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?

Type of Improvement

  • removal of deprecated API

API Impact

  • remove previously deprecated package, users should use chisel3.assert etc. directly

Backend Code Generation Impact

  • none

Desired Merge Strategy

  • squash

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ekiwi
remove experimental.verification package
719ff66 
All functions inside this package were deprecated
in the 3.5 release, so it is appropriate to remove
them for 3.6
@ekiwi ekiwi requested a review from sequencer April 29, 2022 02:04
@ekiwi ekiwi added this to the 3.6.0 milestone Apr 29, 2022
@ekiwi ekiwi added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Apr 29, 2022
@mergify mergify bot merged commit 2f80a9e into chipsalliance:master Apr 29, 2022
seldridge
seldridge reviewed Apr 29, 2022
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks for taking care of this @ekiwi!

jackkoenig added a commit that referenced this pull request Feb 28, 2023
@jackkoenig
Fix incorrect deprecation warning for TargetDirAnnotation (#2511)
06ccf51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge left review comments

@sequencer sequencer sequencer approved these changes

Assignees
No one assigned
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ekiwi @seldridge @sequencer