Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single argument Bits.extract #2566

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

jared-barocsi
Copy link
Contributor

This PR adds the .extract function discussed in #2534, but instead being for the purpose of reducing boilerplate code (e.g. assigning a literal to a val, then calling .apply).

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

Adds single argument Bits.extract functions which the existing apply() functions alias to

Backend Code Generation Impact

No impact

Desired Merge Strategy

Squash and merge

Release Notes

Add Bits.extract and alias single-argument .apply() functions to it
This is to make deprecation of the literal bit extract pattern easier by removing the need for lots of boilerplate.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added this to the 3.5.x milestone Jun 7, 2022
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jun 7, 2022
@jackkoenig jackkoenig enabled auto-merge (squash) June 7, 2022 21:38
@jackkoenig jackkoenig merged commit 255c56c into chipsalliance:master Jun 7, 2022
mergify bot pushed a commit that referenced this pull request Jun 7, 2022
@mergify mergify bot added the Backported This PR has been backported label Jun 7, 2022
mergify bot added a commit that referenced this pull request Jun 7, 2022
(cherry picked from commit 255c56c)

Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com>
jackkoenig added a commit that referenced this pull request Feb 28, 2023
Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants