Added migration for inferModuleReset #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
approved these changes
Jun 8, 2022
Comment on lines
+15
to
+25
| val migrateIR = new chisel3.CompileOptions { | ||
| val connectFieldsMustMatch = false | ||
| val declaredTypeMustBeUnbound = false | ||
| val dontTryConnectionsSwapped = false | ||
| val dontAssumeDirectionality = false | ||
| val checkSynthesizable = false | ||
| val explicitInvalidate = false | ||
| val inferModuleReset = false | ||
|
|
||
| override val migrateInferModuleReset = true | ||
| } |
There was a problem hiding this comment.
If we're going to adopt this new technique of "migration" compile options, I think we should consider some factory methods to construct them from Strict and NotStrict, I'm thinking something like:
object CompileOptions {
def migrationFromStrict(migrateInferModuleReset: Boolean = false): CompileOptions = ...
}Anyway, I don't think it should be part of this PR, but if we are to sort of standardize on this technique I think a little bit of help for users would be warranted, otherwise this is a very power user-y API.
Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
jackkoenig
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
Co-authored-by: Jack Koenig <koenig@sifive.com> (cherry picked from commit 3c6c044) # Conflicts: # core/src/main/scala/chisel3/Module.scala
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
Co-authored-by: Jack Koenig <koenig@sifive.com> (cherry picked from commit 3c6c044)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?I didn't add more comprehensive ScalaDoc. I will add that once we add migration options for all the compilation options.
Type of Improvement
API Impact
Adds another optional field to CompileOptions to migrate inferModuleReset.
Desired Merge Strategy
Squash
Release Notes
Added an optional field to CompileOptions to help users migrate the inferModuleReset compile option.
Reviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.