Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro-optimize and memoize BitPat.rawString #2577

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

jackkoenig
Copy link
Contributor

BitPat.rawString is called a lot when decoding and is used for certain
BitPat operations. We should use it less but this is at least a bandaid.

@sequencer, have you noticed issues with this?

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • performance improvement

API Impact

No impact, this should be source and binary compatible

Backend Code Generation Impact

None

Desired Merge Strategy

Squash

Release Notes

Micro-optimize and memoize BitPat.rawString to speed up decoding APIs

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

BitPat.rawString is called a lot when decoding and is used for certain
BitPat operations. We should use it less but this is at least a bandaid.
@jackkoenig jackkoenig added this to the 3.5.x milestone Jun 10, 2022
@jackkoenig jackkoenig enabled auto-merge (squash) June 10, 2022 22:36
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jun 10, 2022
@jackkoenig jackkoenig merged commit c11af20 into master Jun 10, 2022
@jackkoenig jackkoenig deleted the micro-optimize-bitpat-rawstring branch June 10, 2022 23:12
mergify bot pushed a commit that referenced this pull request Jun 10, 2022
BitPat.rawString is called a lot when decoding and is used for certain
BitPat operations. We should use it less but this is at least a bandaid.

(cherry picked from commit c11af20)
@mergify mergify bot added the Backported This PR has been backported label Jun 10, 2022
mergify bot added a commit that referenced this pull request Jun 11, 2022
BitPat.rawString is called a lot when decoding and is used for certain
BitPat operations. We should use it less but this is at least a bandaid.

(cherry picked from commit c11af20)

Co-authored-by: Jack Koenig <koenig@sifive.com>
@sequencer
Copy link
Member

@sequencer, have you noticed issues with this?

Sorry, I didn't test the performance issue in the Scala side, I will take care of those in the future. For most of the time, I have been using pure functional paradigm, however when it comes to these cases, the performance will be embarrassing... Sorry about that.

image

jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants