Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish unidoc as ScalaDoc in chisel project #2595

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Publish unidoc as ScalaDoc in chisel project #2595

merged 2 commits into from
Jun 22, 2022

Conversation

jackkoenig
Copy link
Contributor

This makes it such that we can stop hosting ScalaDoc on the Chisel
website, instead just pointing to the latest docs on javadoc.io

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • [NA] Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • documentation

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig
Publish unidoc as ScalaDoc in chisel project
c51ccee 
This makes it such that we can stop hosting ScalaDoc on the Chisel
website, instead just pointing to the latest docs on javadoc.io
@jackkoenig jackkoenig added this to the 3.4.x milestone Jun 22, 2022
seldridge
seldridge approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jun 22, 2022
@jackkoenig jackkoenig enabled auto-merge (squash) June 22, 2022 16:11
@jackkoenig jackkoenig merged commit 8b9f3d7 into master Jun 22, 2022
@jackkoenig jackkoenig deleted the publish-unidoc branch June 22, 2022 16:56
mergify bot pushed a commit that referenced this pull request Jun 22, 2022
@jackkoenig @mergify
Publish unidoc as ScalaDoc in chisel project (#2595)
bf2d374 
This makes it such that we can stop hosting ScalaDoc on the Chisel
website, instead just pointing to the latest docs on javadoc.io

(cherry picked from commit 8b9f3d7)

# Conflicts:
#	build.sbt
@mergify mergify bot mentioned this pull request Jun 22, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jun 22, 2022
@jackkoenig @mergify
Publish unidoc as ScalaDoc in chisel project (#2595)
78f7073 
This makes it such that we can stop hosting ScalaDoc on the Chisel
website, instead just pointing to the latest docs on javadoc.io

(cherry picked from commit 8b9f3d7)

# Conflicts:
#	build.sbt
@mergify mergify bot mentioned this pull request Jun 22, 2022
Merged
@mergify mergify bot added the Backported This PR has been backported label Jun 22, 2022
mergify bot added a commit that referenced this pull request Jun 23, 2022
@mergify @jackkoenig
Publish unidoc as ScalaDoc in chisel project (backport #2595) (#2597)
139a52b 
* Publish unidoc as ScalaDoc in chisel project (#2595)

This makes it such that we can stop hosting ScalaDoc on the Chisel
website, instead just pointing to the latest docs on javadoc.io

(cherry picked from commit 8b9f3d7)

# Conflicts:
#	build.sbt

* Resolve backport conflicts

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request Jun 23, 2022
@mergify @jackkoenig
Publish unidoc as ScalaDoc in chisel project (backport #2595) (#2598)
7fc023c 
* Publish unidoc as ScalaDoc in chisel project (#2595)

This makes it such that we can stop hosting ScalaDoc on the Chisel
website, instead just pointing to the latest docs on javadoc.io

(cherry picked from commit 8b9f3d7)

# Conflicts:
#	build.sbt

* Resolve backport conflicts

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
@ekiwi
[smem] fix read-under-write serialization (#2595)
82af22f 
* [smem] fix read-under-write serialization

Also adds some tests for the parser and
the serializer.

* Serializer: always serialize smem ruw behavior

* test: simplify smem test circuit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @seldridge