Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataMirror isIO, isReg, isWire #2601

Merged
merged 7 commits into from
Jun 23, 2022

Conversation

zyedidia
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

This extends the current DataMirror API.

Backend Code Generation Impact

Backend code generation is not changed.

Desired Merge Strategy

Squash

Release Notes

Added DataMirror methods isIO, isReg, isWire for determining the binding of a Chisel type.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2022

CLA assistant check
All committers have signed the CLA.

DataMirror.isIO(io) should be(true)
DataMirror.isIO(io.in) should be(true)
DataMirror.isIO(io.out) should be(true)
DataMirror.isWire(wire) should be(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be cases here for aggregate wires, regs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it would be good to check Aggregates (Bundle and Vec) and child members of those aggregates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the test to have more cases, let me know if it's still missing some desirable cases.

@jackkoenig
Copy link
Contributor

CI failed because you need to run formatting via sbt scalafmtAll

Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just a couple of suggestions.

Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@jackkoenig jackkoenig added this to the 3.5.x milestone Jun 23, 2022
@jackkoenig jackkoenig enabled auto-merge (squash) June 23, 2022 17:44
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jun 23, 2022
@jackkoenig jackkoenig merged commit 7fa0d8b into chipsalliance:master Jun 23, 2022
mergify bot pushed a commit that referenced this pull request Jun 23, 2022
@mergify mergify bot added the Backported This PR has been backported label Jun 23, 2022
mergify bot added a commit that referenced this pull request Jun 23, 2022
(cherry picked from commit 7fa0d8b)

Co-authored-by: Zachary Yedidia <zyedidia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants