-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DataMirror isIO, isReg, isWire #2601
Conversation
DataMirror.isIO(io) should be(true) | ||
DataMirror.isIO(io.in) should be(true) | ||
DataMirror.isIO(io.out) should be(true) | ||
DataMirror.isWire(wire) should be(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be cases here for aggregate wires, regs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it would be good to check Aggregates (Bundle and Vec) and child members of those aggregates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the test to have more cases, let me know if it's still missing some desirable cases.
CI failed because you need to run formatting via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, just a couple of suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work!
(cherry picked from commit 7fa0d8b)
Contributor Checklist
docs/src
?Type of Improvement
API Impact
This extends the current DataMirror API.
Backend Code Generation Impact
Backend code generation is not changed.
Desired Merge Strategy
Squash
Release Notes
Added
DataMirror
methodsisIO
,isReg
,isWire
for determining the binding of a Chisel type.Reviewer Checklist (only modified by reviewer)
3.4.x
, [small] API extension:3.5.x
, API modification or big change:3.6.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.