Add OpaqueType support to Records #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adkian-sifive
force-pushed
the
record-opaque-type
branch
from
54f49f7
to
f3951aa
Compare
hcook
reviewed
Aug 5, 2022
mwachs5
reviewed
Aug 5, 2022
mwachs5
reviewed
Aug 5, 2022
mwachs5
reviewed
Aug 5, 2022
adkian-sifive
commented
Aug 8, 2022
jackkoenig
requested changes
Aug 11, 2022
jackkoenig
approved these changes
Aug 12, 2022
jackkoenig
reviewed
Aug 12, 2022
jackkoenig
reviewed
Aug 12, 2022
Add new slot type and handle slot type in convert. add opaqueType override to Record
update converter for OpaqueSlot
Run scalafmt
update docstring
Co-authored-by: Jack Koenig <jack.koenig3@gmail.com>
adkian-sifive
force-pushed
the
record-opaque-type
branch
from
443334b
to
3c47e64
Compare
jackkoenig
approved these changes
Aug 13, 2022
jackkoenig
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Aug 13, 2022
OpaqueTypes are essentially type aliases that hide the underlying type. They are implemented in Chisel as Records of a single, unnamed element where the wrapping Record does not exist in the emitted FIRRTL. Co-authored-by: Jack Koenig <koenig@sifive.com> (cherry picked from commit df5afee)
|
Github automerged this even though CI failed.... that's weird. I'll push a fix |
mergify bot
added a commit
that referenced
this pull request
Aug 16, 2022
* Add OpaqueType support to Records (#2662) OpaqueTypes are essentially type aliases that hide the underlying type. They are implemented in Chisel as Records of a single, unnamed element where the wrapping Record does not exist in the emitted FIRRTL. Co-authored-by: Jack Koenig <koenig@sifive.com> (cherry picked from commit df5afee) * Fix test compilation * Fix OpaqueType tests in RecordSpec Need to implement cloneType correctly and to warn instead of error when accessing .toTarget of non-hardware types because that is a warning (not error) in 3.5. * Waive MiMa false positives Co-authored-by: Aditya Naik <91489422+adkian-sifive@users.noreply.github.com> Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpaqueTypeallows simplifyingRecordreferences when theRecordsubtypes have single map elementsContributor Checklist
docs/src?Type of Improvement
API Impact
New override for Records for single element types
Backend Code Generation Impact
If
Record.opaqueTypeis overridden totrue, the generated CHIRRTL will substitute name of theRecordfor that of the subfield, and substitute type of the subfield for type of theRecordDesired Merge Strategy
Release Notes
Add new override in Record to support opaque types
Reviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.