-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @chiselName and NoChiselNamePrefix #2694
Merged
jackkoenig
merged 7 commits into
chipsalliance:master
from
jardhu:remove-chiselname-api
Sep 21, 2022
Merged
Remove @chiselName and NoChiselNamePrefix #2694
jackkoenig
merged 7 commits into
chipsalliance:master
from
jardhu:remove-chiselname-api
Sep 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
reviewed
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good, but there is more stuff to delete
jackkoenig
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sequencer
added a commit
to sequencer/riscv-boom
that referenced
this pull request
Sep 25, 2022
sequencer
added a commit
to chipsalliance/rocket-chip
that referenced
this pull request
Sep 25, 2022
sequencer
added a commit
to sequencer/riscv-boom
that referenced
this pull request
Sep 25, 2022
sequencer
added a commit
to chipsalliance/playground
that referenced
this pull request
Sep 25, 2022
sequencer
added a commit
to chipsalliance/rocket-chip
that referenced
this pull request
Sep 25, 2022
sequencer
added a commit
to chipsalliance/rocket-chip
that referenced
this pull request
Oct 7, 2022
SingularityKChen
pushed a commit
to SingularityKChen/rocket-chip
that referenced
this pull request
Oct 11, 2022
jerryz123
pushed a commit
to riscv-boom/riscv-boom
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Officially removes
@chiselName
and its related API.Contributor Checklist
docs/src
?Type of Improvement
API Impact
Removes
@chiselName
andNoChiselNamePrefix
APIBackend Code Generation Impact
No impact
Desired Merge Strategy
Squash and merge
Release Notes
Reviewer Checklist (only modified by reviewer)
3.4.x
, [small] API extension:3.5.x
, API modification or big change:3.6.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.