Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @chiselName and NoChiselNamePrefix #2694

Merged
merged 7 commits into from
Sep 21, 2022

Conversation

jared-barocsi
Copy link
Contributor

Officially removes @chiselName and its related API.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • code cleanup

API Impact

Removes @chiselName and NoChiselNamePrefix API

Backend Code Generation Impact

No impact

Desired Merge Strategy

Squash and merge

Release Notes

  • @chiselName and NoChiselName is now entirely removed

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added this to the 3.6.0 milestone Aug 23, 2022
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good, but there is more stuff to delete

Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackkoenig jackkoenig enabled auto-merge (squash) September 20, 2022 22:19
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Sep 20, 2022
@jackkoenig jackkoenig merged commit 86e1130 into chipsalliance:master Sep 21, 2022
sequencer added a commit to sequencer/riscv-boom that referenced this pull request Sep 25, 2022
sequencer added a commit to chipsalliance/rocket-chip that referenced this pull request Sep 25, 2022
sequencer added a commit to sequencer/riscv-boom that referenced this pull request Sep 25, 2022
sequencer added a commit to chipsalliance/playground that referenced this pull request Sep 25, 2022
sequencer added a commit to chipsalliance/rocket-chip that referenced this pull request Sep 25, 2022
sequencer added a commit to chipsalliance/rocket-chip that referenced this pull request Oct 7, 2022
SingularityKChen pushed a commit to SingularityKChen/rocket-chip that referenced this pull request Oct 11, 2022
jerryz123 pushed a commit to riscv-boom/riscv-boom that referenced this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants