Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpaqueSlot handling of contextual names #2708

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Conversation

jackkoenig
Copy link
Contributor

We need to ensure that contextual names stay contextual (ie. sensitive
to the module context which is important for naming ports).

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

This is a bug fix in a not-yet-released feature

Type of Improvement

  • bug fix

API Impact

No impact, just a minor bug fix

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

We need to ensure that contextual names stay contextual (ie. sensitive
to the module context which is important for naming ports).
@jackkoenig jackkoenig added this to the 3.5.x milestone Aug 29, 2022
@hcook hcook self-requested a review August 29, 2022 17:32
@jackkoenig jackkoenig enabled auto-merge (squash) August 29, 2022 19:17
@jackkoenig jackkoenig merged commit cee2552 into master Aug 29, 2022
@jackkoenig jackkoenig deleted the opaque-slot-bugfix branch August 29, 2022 20:05
mergify bot pushed a commit that referenced this pull request Aug 29, 2022
We need to ensure that contextual names stay contextual (ie. sensitive
to the module context which is important for naming ports).

(cherry picked from commit cee2552)
@mergify mergify bot added the Backported This PR has been backported label Aug 29, 2022
mergify bot added a commit that referenced this pull request Aug 29, 2022
We need to ensure that contextual names stay contextual (ie. sensitive
to the module context which is important for naming ports).

(cherry picked from commit cee2552)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants