Remove incorrect clock warning on Mem.read #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswaterman
force-pushed
the
fix-clock-warning
branch
from
a754b37
to
407a6f3
Compare
Mem.read is combinational and thus unaffected by the clock, and so it does not make sense to issue warnings about the current clock in this context.
aswaterman
force-pushed
the
fix-clock-warning
branch
from
407a6f3
to
f9044f2
Compare
jackkoenig
approved these changes
Sep 1, 2022
jackkoenig
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
Mem.read is combinational and thus unaffected by the clock, and so it does not make sense to issue warnings about the current clock in this context. (cherry picked from commit 5fdf74f)
mergify bot
added a commit
that referenced
this pull request
Sep 1, 2022
* Remove incorrect clock warning on Mem.read (#2721) Mem.read is combinational and thus unaffected by the clock, and so it does not make sense to issue warnings about the current clock in this context. (cherry picked from commit 5fdf74f) * Keep old version of MemBase.clockWarning for binary compatibility This method is impossible for users to call, but it is easy enough to keep around a version of it to make MiMa happy. Co-authored-by: Andrew Waterman <andrew@sifive.com> Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mem.read is combinational and thus unaffected by the clock, and so it does not make sense to issue warnings about the current clock in this context.
Contributor Checklist
adddelete at least one test demonstrating the PR?docs/src?Type of Improvement
API Impact
None.
Backend Code Generation Impact
None.
Desired Merge Strategy
Release Notes
Removed deprecation warning when reading a Mem when the current implicit clock differs from the implicit clock at time of definition.
Reviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.