Switch from YosysHQ action to reusable workflow #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The YosysHQ Github Action for setting up the OSS CAD Suite is very flaky in CI so instead we can just wget and untar the suite ourselves. It also seems prudent to try out reusable workflows to avoid duplication of installation steps.
jackkoenig
force-pushed
the
update-setup-oss-cad-suite
branch
from
8d92867
to
fe65a8d
Compare
|
I was originally trying to use reusable workflows, but (1) AFAICT the docs are just wrong, and more importantly (2) it seems that those run on different runners so aren't useful for setting up stuff. So instead I'm trying out composite actions. |
seldridge
approved these changes
Dec 19, 2022
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
The YosysHQ Github Action for setting up the OSS CAD Suite is very flaky in CI so instead we can just wget and untar the suite ourselves. It also seems prudent to try out composite actions to avoid duplication of installation steps. (cherry picked from commit 75aeaed) # Conflicts: # .github/workflows/test.yml
mergify bot
added a commit
that referenced
this pull request
Dec 20, 2022
* Switch from YosysHQ action to composite action (#2901) The YosysHQ Github Action for setting up the OSS CAD Suite is very flaky in CI so instead we can just wget and untar the suite ourselves. It also seems prudent to try out composite actions to avoid duplication of installation steps. (cherry picked from commit 75aeaed) # Conflicts: # .github/workflows/test.yml * Resolve backport conflicts Co-authored-by: Jack Koenig <koenig@sifive.com>
jackkoenig
added a commit
to chipsalliance/firrtl
that referenced
this pull request
Jan 13, 2023
jackkoenig
added a commit
to chipsalliance/firrtl
that referenced
this pull request
Jan 13, 2023
jackkoenig
added a commit
to chipsalliance/firrtl
that referenced
this pull request
Jan 13, 2023
mergify bot
pushed a commit
to chipsalliance/firrtl
that referenced
this pull request
Jan 13, 2023
Based on chipsalliance/chisel#2901. (cherry picked from commit 59f62d8)
mergify bot
added a commit
to chipsalliance/firrtl
that referenced
this pull request
Jan 13, 2023
Based on chipsalliance/chisel#2901. (cherry picked from commit 59f62d8) Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The YosysHQ Github Action for setting up the OSS CAD Suite is very flaky in CI so instead we can just wget and untar the suite ourselves. It also seems prudent to try out reusable workflows to avoid duplication of installation steps.
Contributor Checklist
docs/src?Type of Improvement
API Impact
No impact
Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.