Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring ToC and Menu into alignment, some minor cleanup within docs #3346

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Bring ToC and Menu into alignment, some minor cleanup within docs #3346

merged 1 commit into from
Jun 9, 2023

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented Jun 9, 2023

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

  • Documentation or website-related

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Fix #3322

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mwachs5 mwachs5 added the Documentation Only changing documentation label Jun 9, 2023
@mwachs5 mwachs5 added this to the 3.6.x milestone Jun 9, 2023
@mwachs5 mwachs5 requested a review from azidar June 9, 2023 00:30
@jackkoenig jackkoenig modified the milestones: 3.6.x, 5.x Jun 9, 2023
@jackkoenig
Copy link
Contributor

Changed milestone to 5.x because that's when we brought the website in tree.

@jackkoenig jackkoenig merged commit e718aac into main Jun 9, 2023
@jackkoenig jackkoenig deleted the fix-website-menus branch June 9, 2023 17:12
@mergify mergify bot added the Backported This PR has been backported label Jun 9, 2023
mergify bot pushed a commit that referenced this pull request Jun 9, 2023
@mwachs5 @mergify
Bring ToC and Menu into alignment, some minor cleanup within docs (#3346
42f966e 
)

(cherry picked from commit e718aac)
@mergify mergify bot mentioned this pull request Jun 9, 2023
Merged
14 tasks
mergify bot added a commit that referenced this pull request Jun 9, 2023
@mergify @mwachs5
Bring ToC and Menu into alignment, some minor cleanup within docs (#3346
247ac7c 
) (#3347)

(cherry picked from commit e718aac)

Co-authored-by: Megan Wachs <megan@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

@azidar azidar Awaiting requested review from azidar

Assignees
No one assigned
Labels
Backported This PR has been backported Documentation Only changing documentation
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.

[website] inconsistent ordering on Explanations on Menu vs ToC
2 participants
@mwachs5 @jackkoenig