Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to FIRRTL 4.0.0 #3803

Merged
merged 1 commit into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions firrtl/src/main/scala/firrtl/ir/Serializer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ object Serializer {
val Indent = " "

// The version supported by the serializer.
val version = Version(3, 3, 0)
val version = Version(4, 0, 0)

/** Converts a `FirrtlNode` into its string representation with
* default indentation.
Expand Down Expand Up @@ -230,7 +230,7 @@ object Serializer {
indent -= 1
case LayerBlockBegin(info, layer) =>
doIndent()
b ++= s"group $layer :"; s(info)
b ++= s"layerblock $layer :"; s(info)
indent += 1
case LayerBlockEnd =>
indent -= 1
Expand Down Expand Up @@ -527,7 +527,7 @@ object Serializer {
val layers = if (circuit.layers.nonEmpty) {
implicit val b = new StringBuilder
def layerIt(layer: Layer)(implicit indent: Int): Unit = {
b ++= s"${NewLine}"; doIndent(); b ++= s"declgroup ${layer.name}, ${layer.convention} :"
b ++= s"${NewLine}"; doIndent(); b ++= s"layer ${layer.name}, ${layer.convention} :"
s(layer.info)
layer.body.foreach(layerIt(_)(indent + 1))
}
Expand Down
2 changes: 1 addition & 1 deletion firrtl/src/test/scala/firrtlTests/ExtModuleTests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import firrtl.testutils._
class ExtModuleTests extends FirrtlFlatSpec {
"extmodule" should "serialize and re-parse equivalently" in {
val input =
"""|FIRRTL version 3.3.0
"""|FIRRTL version 4.0.0
|circuit Top :
| extmodule Top :
| input y : UInt<0>
Expand Down
8 changes: 4 additions & 4 deletions src/test/scala/chiselTests/LayerSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ class LayerSpec extends ChiselFlatSpec with Utils with MatchesAndOmits {
info("CHIRRTL emission looks coorect")
// TODO: Switch to FileCheck for this testing. This is going to miss all sorts of ordering issues.
matchesAndOmits(chirrtl)(
"declgroup A, bind :",
"declgroup B, bind :",
"group A :",
"layer A, bind :",
"layer B, bind :",
"layerblock A :",
"wire w : UInt<1>",
"group B :",
"layerblock B :",
"wire x : UInt<1>",
"wire y : UInt<1>"
)()
Expand Down
2 changes: 1 addition & 1 deletion src/test/scala/circtTests/stage/ChiselStageSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,7 @@ class ChiselStageSpec extends AnyFunSpec with Matchers with chiselTests.Utils {

val text = ChiselStage.emitCHIRRTL(new ChiselStageSpec.Foo(hasDontTouch = true))
info("found a version string")
text should include("FIRRTL version 3.3.0")
text should include("FIRRTL version 4.0.0")
info("found an Annotation")
text should include("firrtl.transforms.DontTouchAnnotation")
info("found a circuit")
Expand Down
Loading