Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to firtool-resolver 2.0.0 #3855

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Feb 23, 2024

This is largely a non-breaking change, but firtool-resolver 2.0.0 is a big change in that it drops a lot of transitive dependencies which could be accidentally relied upon by downstream users. Also, the firtool-resolver API changed types for its Logger. It used to use scribe, but to reduce dependencies, it has been changed to its own very lightweight Logger API, you can see the simple shim in this PR.

This version will work on 5.x and 3.6.x but sadly should not be backported to 6.x as it does break binary compatibility.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API modification

Desired Merge Strategy

  • Squash

Release Notes

This change should be non-breaking for the vast majority of users; however, it does have a substantial impact on Chisel's transitive dependencies which could affect some users. The following transitive dependencies were dropped:

  • com.github.luben:zstd-jni:1.5.5-10
  • com.github.plokhotnyuk.jsoniter-scala::jsoniter-scala-core:2.13.5.2
  • com.lihaoyi::sourcecode:0.3.1
  • com.outr::moduload:1.1.7
  • com.outr::perfolation:1.2.9
  • com.outr::scribe:3.13.0
  • commons-io:commons-io:2.15.0
  • io.get-coursier.jniutils:windows-jni-utils:0.3.3
  • io.get-coursier::coursier-cache:2.1.8
  • io.get-coursier::coursier-core:2.1.8
  • io.get-coursier::coursier-proxy-setup:2.1.8
  • io.get-coursier::coursier-util:2.1.8
  • io.get-coursier::coursier:2.1.8
  • io.github.alexarchambault.windows-ansi:windows-ansi:0.0.5
  • io.github.alexarchambault:concurrent-reference-hash-map:1.1.0
  • javax.inject:javax.inject:1
  • org.apache.commons:commons-compress:1.24.0
  • org.apache.xbean:xbean-reflect:3.7
  • org.codehaus.plexus:plexus-archiver:4.9.0
  • org.codehaus.plexus:plexus-classworlds:2.6.0
  • org.codehaus.plexus:plexus-container-default:2.1.1
  • org.codehaus.plexus:plexus-io:3.4.1
  • org.codehaus.plexus:plexus-utils:4.0.0
  • org.fusesource.jansi:jansi:1.18
  • org.iq80.snappy:snappy:0.4
  • org.slf4j:slf4j-api:1.7.36
  • org.tukaani:xz:1.9
  • org.virtuslab.scala-cli::config:0.2.1

Any users experiencing issues should consider manually adding whichever of these dependencies they may be relying on.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added this to the 7.0 milestone Feb 23, 2024
@jackkoenig jackkoenig requested a review from seldridge February 23, 2024 02:39
@jackkoenig jackkoenig force-pushed the jackkoenig/firtool-resolver-2 branch from bc9a795 to b374c4e Compare February 23, 2024 02:48
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackkoenig jackkoenig merged commit eadde6f into main Feb 23, 2024
14 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/firtool-resolver-2 branch February 23, 2024 06:40
sequencer pushed a commit that referenced this pull request Feb 28, 2024
SpriteOvO pushed a commit to SpriteOvO/chisel that referenced this pull request Mar 2, 2024
SpriteOvO pushed a commit to SpriteOvO/chisel that referenced this pull request Mar 2, 2024
SpriteOvO pushed a commit to SpriteOvO/chisel that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants