Don't warn when 0.U used as value for 0-bit BundleLit field #4097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to add this special-case is a shame, but worthwhile. Basically, if a user writes something like:
We should not warn if
field2
is 0-bit and that expression evaluates to0
, it's way too onerous to expect the user to handle passing0.W
to.U
in this case. I think a similar thing will come up when we start warning/removing implicit truncation. It's a special-case, but it's pragmatic.The best fix would be for
0.U
to start being zero-width, but that has a ton of knock on effects and should be considered a breaking change and handled as such.Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.