-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build (verilog) fails if "CONFIG=..." specified on makefile commandline #2321
Comments
I believe this needs the full package name, e.g., |
Could you try add SUB_PROJECT=rocketchip to the make command?
…On Fri, Mar 6, 2020 at 1:00 AM gsomlo ***@***.***> wrote:
*Type of issue*: bug report
*Impact*: unknown
*Development Phase*: request
*Other information*
*If the current behavior is a bug, please provide the steps to reproduce
the problem:*
git clone https://github.com/chipsalliance/rocket-chip
cd rocket-chip
make RISCV=${HOME}/RISCV -C vsim verilog CONFIG=DefaultConfig
*What is the current behavior?*
[info] running freechips.rocketchip.system.Generator -td /home/somlo/rocket-chip/vsim/generated-src -T freechips.rocketchip.system.TestHarness -C DefaultConfig
[error] (run-main-0) java.lang.Exception: Unable to find part "DefaultConfig" from "ArrayBuffer(DefaultConfig)", did you misspell it?
[error] java.lang.Exception: Unable to find part "DefaultConfig" from "ArrayBuffer(DefaultConfig)", did you misspell it? 2s
[error] at Chisel.package$throwException$.apply(compatibility.scala:423)
[error] at freechips.rocketchip.util.HasRocketChipStageUtils.$anonfun$getConfig$1(GeneratorUtils.scala:19)
[error] at scala.collection.IndexedSeqOptimized.foldRight(IndexedSeqOptimized.scala:65)
[error] at scala.collection.IndexedSeqOptimized.foldRight$(IndexedSeqOptimized.scala:72)
[error] at scala.collection.mutable.ArrayBuffer.foldRight(ArrayBuffer.scala:49)
[error] at freechips.rocketchip.util.HasRocketChipStageUtils.getConfig(GeneratorUtils.scala:14)
[error] at freechips.rocketchip.util.HasRocketChipStageUtils.getConfig$(GeneratorUtils.scala:13)
[error] at freechips.rocketchip.stage.phases.PreElaboration.getConfig(PreElaboration.scala:16)
[error] at freechips.rocketchip.stage.phases.PreElaboration.transform(PreElaboration.scala:26)
[error] at freechips.rocketchip.stage.phases.PreElaboration.transform(PreElaboration.scala:16)
[error] at firrtl.options.phases.DeletedWrapper.internalTransform(DeletedWrapper.scala:32)
[error] at firrtl.options.phases.DeletedWrapper.internalTransform(DeletedWrapper.scala:15)
[error] at firrtl.options.Translator.transform(Phase.scala:140)
[error] at firrtl.options.Translator.transform$(Phase.scala:140)
[error] Caused by: java.lang.ClassNotFoundException: DefaultConfig
[error] at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
[error] at sbt.internal.ManagedClassLoader.findClass(ManagedClassLoader.java:92)
[error] at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
[error] at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
[error] at java.lang.Class.forName0(Native Method)
[error] at java.lang.Class.forName(Class.java:264)
[error] at freechips.rocketchip.util.HasRocketChipStageUtils.$anonfun$getConfig$1(GeneratorUtils.scala:16)
[error] at scala.collection.IndexedSeqOptimized.foldRight(IndexedSeqOptimized.scala:65)
[error] at scala.collection.IndexedSeqOptimized.foldRight$(IndexedSeqOptimized.scala:72)
[error] at scala.collection.mutable.ArrayBuffer.foldRight(ArrayBuffer.scala:49)
[error] at freechips.rocketchip.util.HasRocketChipStageUtils.getConfig(GeneratorUtils.scala:14)
[error] at freechips.rocketchip.util.HasRocketChipStageUtils.getConfig$(GeneratorUtils.scala:13)
[error] at freechips.rocketchip.stage.phases.PreElaboration.getConfig(PreElaboration.scala:16)
[error] at freechips.rocketchip.stage.phases.PreElaboration.transform(PreElaboration.scala:26)
[error] Nonzero exit code: 1
[error] (Compile / runMain) Nonzero exit code: 1
[error] Total time: 48 s, completed Mar 5, 2020 11:49:58 AM
*NOTE*: if CONFIG=DefaultConfig is left out, the verilog for the default
config is built without problems. However, I would like to build something
*other* than the DefaultConfig, and can't select it on the make command
line as things stand right now!
*What is the expected behavior?*
Verilog for the selected configuration is built without error.
*Please tell us about your environment:*
Fedora 30, x86_64
*What is the use case for changing the behavior?*
Selecting a configuration *other* than DefaultConfig.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2321?email_source=notifications&email_token=AIM5RADOET3FJOFDPGDVWU3RF7LERA5CNFSM4LCOIJX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IS3EY7Q>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIM5RAA33XYYJAZ2L6UOFP3RF7LERANCNFSM4LCOIJXQ>
.
|
Adding Spelling it out as FTR, bisect says the change was introduced by commit |
Yeah, that changed with #2274. Specifically see the top level Clarifying, I think that is the canonical way of doing things. The README and other documentation likely needs to be updated. Sorry about that! |
Ah yes, my bad! You do need to specify the entire project/config for |
This new information puts me back in business. Feel free to close this issue if/when the README has been updated. Thanks again to all of you! |
Updated — thanks for raising this, @gsomlo! |
looks like as of right now (commit 38c2903) things are back to the old behavior ( Thanks much, as usual! |
Yes the intention is to keep the “new” behavior within a week or two
On Sun, Mar 29, 2020 at 4:57 PM gsomlo ***@***.***> wrote:
looks like as of right now (commit 38c2903
<38c2903>)
things are back to the old behavior (CONFIG=DefaultConfig, i.e. without
the prepended freechips.rocketchip.system). Is the revert temporary, i.e.
is the "new" behavior likely to be put back in place? I have a downstream
project depending on Rocket, and would like to know whether to wait it out
or whether to add my own revert of the freechips.rocketchip.system
prepend?
Thanks much, as usual!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIIAJDGRGP23GF2ZBLUHCDRJ7N4ZANCNFSM4LCOIJXQ>
.
--
Megan A. Wachs
VP of Engineering | SiFive, Inc
1875 South Grant Street
Suite 600
San Mateo, CA 94402
megan@sifive.com
|
Type of issue: bug report
Impact: unknown
Development Phase: request
Other information
If the current behavior is a bug, please provide the steps to reproduce the problem:
What is the current behavior?
NOTE: if
CONFIG=DefaultConfig
is left out, the verilog for the default config is built without problems. However, I would like to build something other than theDefaultConfig
, and can't select it on themake
command line as things stand right now!What is the expected behavior?
Verilog for the selected configuration is built without error.
Please tell us about your environment:
Fedora 30, x86_64
What is the use case for changing the behavior?
Selecting a configuration other than
DefaultConfig
.The text was updated successfully, but these errors were encountered: