Teach MulDiv to do div-only #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this configuration expressible via ISA string? Like is it still "M"? What happens when a mul instruction ends up in a binary accidentally? |
|
The intent isn't to remove instructions from the ISA (note this doesn't change the instruction decoder), it just allows processors to implement the MUL instructions with a different unit than the divider, e.g., a fully-pipelined multiplier. |
hcook
approved these changes
Feb 6, 2018
MULHSU and MULHU should match their ISA funct3 encodings to slightly reduce HW cost.
I also renamed badaddr to tval (the correct name).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.