Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsystem: Add HierarchicalLocation #2346

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Conversation

rmac-sifive
Copy link
Contributor

Related issue:

Type of change: other enhancement

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes
Adding HierarchicalLocation which config keys may use to control hierarchy of instantiation

@erikdanie erikdanie self-requested a review March 19, 2020 16:45
Copy link
Member

@hcook hcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take the one from my PR?
https://github.com/chipsalliance/rocket-chip/pull/2327/files#diff-3d87f78ef4648ef6b47c853c4581a47bR17

and then the two objects supply string names matching their own class names?

@hcook
Copy link
Member

hcook commented Mar 20, 2020

Sorry, might be a bug in my PR, but here is my code proposal:

 class HierarchicalLocation(override val name: String) extends Location[LazyScope](name)    
 case object InTile extends HierarchicalLocation("InTile")                                  
 case object InSubsystem extends HierarchicalLocation("InSubsystem")                        
 case object InSystem extends HierarchicalLocation("InSystem")

@rmac-sifive rmac-sifive force-pushed the hierarchical-location branch from 3ad407a to fa23fcb Compare March 20, 2020 23:22
@rmac-sifive rmac-sifive merged commit 19da215 into master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants