build.wake: Fix string interpolation of bootrom path. #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah I’ll be more careful with that in future |
jackkoenig
approved these changes
Jun 25, 2020
No worries, I've totally made that mistake too, and in other languages as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: bug report
Impact: no functional change
Development Phase: implementation
Release Notes
I can't actually add @mmjconolly as a reviewer, since he does not have write access to this repo, so @jackkoenig will have to be one to actually approve this PR.
In #2526, one of the strings that we changed was a single-quoted string, which does not do string interpolation, which resulted in a string that literally had a value of
{rocketChipRoot}/bootrom/bootrom.img. This fixes it to be a double-quoted string, which is interpolated.BTW, if either of you knows how to set up a Vim syntax highlighting file to specially highlight interpolated expressions within a string, it'd be nice to get this into the Wake Vim syntax highlighting file so that it's more obvious when a string is not interpolated: https://github.com/sifive/wake/blob/96a0323d49ab12a9313ec0b4c385329e2d0f4232/share/doc/wake/syntax/vim/syntax/wake.vim