Make StoreGen support narrow typ field #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, the git commit is a little dirty, can you rebase? |
|
This should wait until after #3478 . After that, this should have clean diff |
This makes it a bit easier to use the StoreGen circuit. StoreGen shouldn't error if the `typ` argument is narrower than `maxSize` would normally permit.
jerryz123
force-pushed
the
jerryz123-patch-1
branch
from
091fe41
to
9a416a1
Compare
sequencer
approved these changes
Sep 17, 2023
|
@Mergifyio copy master |
✅ Pull request copies have been created
|
jerryz123
added a commit
that referenced
this pull request
Sep 26, 2023
Make StoreGen support narrow typ field (copy #3479)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a bit easier to use the StoreGen circuit. StoreGen shouldn't error if the
typargument is narrower thanmaxSizewould normally permit.Related issue:
Type of change: bug report | feature request | other enhancement
Impact: no functional change | API addition (no impact on existing code) | API modification
Development Phase: proposal | implementation
Release Notes