Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s1_data when coreDataBits > xLen #3598

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix s1_data when coreDataBits > xLen #3598

merged 1 commit into from
Mar 20, 2024

Conversation

jerryz123
Copy link
Contributor

Related issue:

Type of change: bug report | feature request | other enhancement

Impact: no functional change | API addition (no impact on existing code) | API modification

Development Phase: proposal | implementation

Release Notes

@sequencer
Copy link
Member

decoding vector or custom load store into mem_ctrl.fp may trigger this bug?
I can understand, but for the field fp can be misleading. I personal think we need add some inline doc to it...

Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add, we can review and refactor it later.

@jerryz123
Copy link
Contributor Author

This does not affect vector instructions with scalar for scalar fp operands... this only affects FP stores when coreDataBits > xLen. So I think the condition is correct, and clear.

@jerryz123 jerryz123 merged commit b7e4f05 into dev Mar 20, 2024
26 checks passed
@jerryz123 jerryz123 deleted the fix_s1_data branch March 20, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants