-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rtl] refactor mask unit. #788
Open
qinjun-li
wants to merge
18
commits into
master
Choose a base branch
from
mask-unit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,664
−1,306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinjun-li
force-pushed
the
mask-unit
branch
4 times, most recently
from
September 27, 2024 07:24
4be97be
to
edeaf74
Compare
qinjun-li
force-pushed
the
mask-unit
branch
4 times, most recently
from
October 9, 2024 10:41
176c09d
to
b146758
Compare
qinjun-li
force-pushed
the
mask-unit
branch
6 times, most recently
from
October 17, 2024 06:20
8f491b2
to
e4bf1cb
Compare
sequencer
force-pushed
the
mask-unit
branch
2 times, most recently
from
October 20, 2024 10:39
66d6994
to
a288353
Compare
qinjun-li
force-pushed
the
mask-unit
branch
2 times, most recently
from
October 22, 2024 08:12
08e8e31
to
4df82a0
Compare
qinjun-li
force-pushed
the
mask-unit
branch
4 times, most recently
from
November 1, 2024 03:42
2319671
to
f45a7e7
Compare
sequencer
requested changes
Nov 1, 2024
t1/src/mask/BitLevelMaskWrite.scala
Outdated
val stageClear: Bool = IO(Output(Bool())) | ||
|
||
val stageClearVec: Seq[Bool] = in.zipWithIndex.map { case (req, index) => | ||
val reqQueue = Queue(req, 4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use DWBB queue
t1/src/mask/BitLevelMaskWrite.scala
Outdated
val readData = readResult(index) | ||
val res = out(index) | ||
|
||
val WaitReadQueue: Queue[BitLevelWriteRequest] = Module(new Queue(chiselTypeOf(req.bits), readVRFLatency)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use DWBB queue
qinjun-li
force-pushed
the
mask-unit
branch
5 times, most recently
from
November 3, 2024 09:20
f5dff9f
to
d038fc2
Compare
qinjun-li
force-pushed
the
mask-unit
branch
6 times, most recently
from
November 7, 2024 07:35
1619791
to
6c9b3e9
Compare
Avimitin
force-pushed
the
mask-unit
branch
2 times, most recently
from
November 8, 2024 09:36
03438a0
to
28537a4
Compare
sequencer
force-pushed
the
mask-unit
branch
2 times, most recently
from
November 9, 2024 19:48
1dd9602
to
90f1e05
Compare
Signed-off-by: Avimitin <dev@avimit.in>
Signed-off-by: Avimitin <dev@avimit.in>
Signed-off-by: Avimitin <dev@avimit.in>
Report CI result at final step might fail when RTL changes causing online driver to fail. And developers might find it hard to get a list of fail tests list to get fixed. This commit move the report step at running stage. Signed-off-by: Avimitin <dev@avimit.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.