move ViolationHandler to common #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1080 +/- ##
==========================================
- Coverage 92.91% 92.91% -0.01%
==========================================
Files 334 335 +1
Lines 22196 22192 -4
==========================================
- Hits 20624 20620 -4
Misses 1572 1572
Continue to review full report at Codecov.
|
hzeller
requested changes
Nov 2, 2021
| @@ -227,14 +227,13 @@ cc_library( | |||
| "//common/analysis:text_structure_linter", | |||
| "//common/analysis:token_stream_lint_rule", | |||
| "//common/analysis:token_stream_linter", | |||
| "//common/strings:diff", | |||
| "//common/analysis:violation_handler", | |||
There was a problem hiding this comment.
I think the verilog_linter_test below also needs this dependency now.
| @@ -34,6 +34,7 @@ | |||
| #include "absl/status/statusor.h" | |||
| #include "absl/strings/match.h" | |||
| #include "absl/strings/string_view.h" | |||
| #include "common/analysis/violation_handler.h" | |||
There was a problem hiding this comment.
... because of this added include.
|
If you add the dependency, this can be merged. |
wsipak
force-pushed
the
wsip/rdformat-refactor
branch
from
13adf51 to
1289f4f
Compare
|
Now |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring step before introducing Reviewdog Diagnostic Format in Verible:
#1018
ViolationHandleris the interface which is supposed to be implemented byViolationPrinter, RDFormat printer, and other potential handlers.This isn't specific to Verilog and thus we place it in
common.