Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ready for ABSL providing a VLOG() implementation. #2055

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Get ready for ABSL providing a VLOG() implementation. #2055

merged 1 commit into from
Dec 19, 2023

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Dec 19, 2023

In the unreleased head of absl, a
VLOG() implementation is available now.
Make sure we can compile with the current and future absl.

In the unreleased head of absl, a
[VLOG()](https://github.com/abseil/abseil-cpp/blob/bae260199fffe782d5a5414bb80cfe49abb1436f/absl/log/absl_vlog_is_on.h)
implementation is available now.
Make sure we can compile with the current and future absl.
@hzeller hzeller requested a review from fangism December 19, 2023 11:02
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4f5d869) 92.95% compared to head (8592f38) 92.95%.

Files Patch % Lines
common/util/init_command_line.cc 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2055      +/-   ##
==========================================
- Coverage   92.95%   92.95%   -0.01%     
==========================================
  Files         357      357              
  Lines       26411    26412       +1     
==========================================
  Hits        24550    24550              
- Misses       1861     1862       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hzeller hzeller merged commit ca0b583 into chipsalliance:master Dec 19, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants