-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --verify option to verilog-formatter. #2062
Added --verify option to verilog-formatter. #2062
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2062 +/- ##
=======================================
Coverage 92.95% 92.95%
=======================================
Files 357 357
Lines 26412 26424 +12
=======================================
+ Hits 24550 24562 +12
Misses 1862 1862 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think this is a good idea! Just a few comments.
To fix the formatting complaints of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this beats writing to a temporary file and then comparing.
@hzeller : Have I met all your expectations based on the code review? If so, please also approve. I don't have write access to this repo, so I will also need you to merge it. |
Thanks, merged! |
Adds a --verify option to verilog-formatter.
This change is inspired by similar options on many other formatting tools to allow a check of any formatting required and then return a non-zero error code if the file would be formatted. This allows the tool with the --verify option to be easily integrated into CICD style-check flows that ensure all source files are formatted correctly.
This change includes 2 tests for this new option.