Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS for Astro Components Purged #407

Closed
6 tasks done
st3phhays opened this issue Jun 12, 2024 · 0 comments · Fixed by #408
Closed
6 tasks done

CSS for Astro Components Purged #407

st3phhays opened this issue Jun 12, 2024 · 0 comments · Fixed by #408
Assignees
@st3phhays
Labels
4 - Done Code has been added to the repository, and has been reviewed by a team member Bug Issues where something has happened which was not expected or intended

Comments

@st3phhays
Copy link
Member

Checklist

  • I confirm there are no unresolved issues reported on the Chocolatey Status page.
  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my problem.
  • I have verified this is not an issue for a specific package.
  • I have verified this issue is not security related.
  • I confirm I am using official, and not unofficial, or modified, Chocolatey products.

What You Are Seeing?

On the docs site, too much CSS is being purged for the Tab Component, which renders odd spacing.

See issue on docs for more details: chocolatey/docs#1007

What is Expected?

This should look "normal" and not so much space.

How Did You Get This To Happen?

See the issue on docs for more details: chocolatey/docs#1007

System Details

n/a

Installed Packages

n/a

Output Log

n/a

Additional Context
@st3phhays st3phhays added the Bug Issues where something has happened which was not expected or intended label Jun 12, 2024
@st3phhays st3phhays self-assigned this Jun 12, 2024
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Jun 12, 2024
@st3phhays
(chocolatey#407) Retain Astro Component CSS
5d0b2e0 
The purgeCSS flow has been adjusted to ensure that
any classes on Astro Components are retained. This
ensures that the Astro Components are styled
correctly.

In addition, this is now checking for a value
when trigger automation for tabs with a multi
version. This ensures no invalid JSON errors.
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Jun 12, 2024
@st3phhays
(chocolatey#407) Bump version to 0.7.2
40a87f6
This was referenced Jun 12, 2024
Merged
Merged
@st3phhays st3phhays added the 3 - Review Code has been added, and is available for review as a pull request label Jun 12, 2024
@st3phhays st3phhays changed the title CSS for Astro Tab Component Purged CSS for Astro Components Purged Jun 12, 2024
steviecoaster added a commit that referenced this issue Jun 12, 2024
@steviecoaster
Merge pull request #408 from st3phhays/astro-tabs
2188941 
(#407) Retain Astro Component CSS
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Jun 12, 2024
@st3phhays
(chocolatey#407) Retain CollapseButton CSS
4a09c5e 
The CSS for the CollapseButton was getting deleted and needed to be added
to the safelist for purgeCSS. Now, with this in place, all buttons show
as they should with the correct styles.
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Jun 12, 2024
@st3phhays
(chocolatey#407) Bump version to 0.7.3
f60e199
@st3phhays st3phhays mentioned this issue Jun 12, 2024
Merged
10 tasks
corbob added a commit that referenced this issue Jun 13, 2024
@corbob
Merge pull request #409 from st3phhays/astro-buttons
368fc0f 
(#407) Retain CollapseButton CSS
@st3phhays st3phhays added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 3 - Review Code has been added, and is available for review as a pull request labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st3phhays st3phhays

Labels
4 - Done Code has been added to the repository, and has been reviewed by a team member Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#407) Retain Astro Component CSS st3phhays/choco-theme
1 participant
@st3phhays