Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1007) Retain Tab Component CSS #1008

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

st3phhays
Copy link
Member

@st3phhays st3phhays commented Jun 12, 2024

Description Of Changes

The purgeCSS flow has been adjusted to ensure that any classes on Astro Components are retained. This ensures that the Astro Components are styled
correctly.

In addition, this is now checking for a value
when trigger automation for tabs with a multi
version. This ensures no invalid JSON errors.

Motivation and Context

We want this to render correctly.

Testing

  1. Review changes at (#407) Retain Astro Component CSS choco-theme#408
  2. Run this PR
  3. Go to http://localhost:5086/en-us/central-management/setup/database/#database-authentication-scenarios
  4. Play with the tab container, and notice it's "normal"
  5. In your browser, open up the Dev Tools, and notice there are no Red JS errors.
  6. If all appear good, merge the PR at (#407) Retain Astro Component CSS choco-theme#408
  7. Notify @st3phhays to release and update choco-theme here and take this PR out of draft.
  8. After updating, this can be merged
  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left-hand side)/
  • Menu structure has been updated

Related Issue

Fixes #1007

@steviecoaster
Copy link
Contributor

@st3phhays This is ready for you

steviecoaster
steviecoaster previously approved these changes Jun 12, 2024
Copy link
Contributor

@steviecoaster steviecoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

The purgeCSS flow has been adjusted to ensure that
any classes on Astro Components are retained. This
ensures that the Astro Components are styled
correctly.

In addition, this is now checking for a value
when trigger automation for tabs with a multi
version. This ensures no invalid JSON errors.
@st3phhays st3phhays marked this pull request as ready for review June 12, 2024 19:30
@st3phhays
Copy link
Member Author

@steviecoaster choco-theme has been updated, this is ready to merge now.

@st3phhays st3phhays requested a review from steviecoaster June 12, 2024 20:12
@steviecoaster steviecoaster merged commit d6530f5 into chocolatey:master Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank space appearing when switching between tabs on doc page
2 participants