Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdrill transaction helper functions #1

Open
wants to merge 10 commits into
base: 5549/xdrill-ledgers
Choose a base branch
from

Conversation

chowbao
Copy link
Owner

@chowbao chowbao commented Jan 10, 2025

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

github issue

xdrill functions for Transactions

Why

Helper functions for Transactions for processors/transforms from stellar-etl for history_transactions found here

Known limitations

  • Refactor of the processor/transforms to be done in separate ticket/pr

@chowbao
Copy link
Owner Author

chowbao commented Jan 10, 2025

Similar problems from stellar#5568 exist in this PR as well

  • pointer data types could be changed to (datatype, bool)
  • utils package is bad practice
  • look out for more existing functions within xdr and ingest

return t.Envelope.Fee()
}

func FeeCharged(t ingest.LedgerTransaction, l xdr.LedgerCloseMeta) *int64 {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamirms how does passing the LedgerTransaction and LCM through parameters look here?

I will note that for operations we'd need to pass 4 parameters xdr.operation, operationIndex, ingest.LedgerTransaction, xdr.LedgerCloseMeta

Does it make sense to go back to adding these all in a struct instead or params?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant