-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xdrill transaction helper functions #1
base: 5549/xdrill-ledgers
Are you sure you want to change the base?
Conversation
Similar problems from stellar#5568 exist in this PR as well
|
return t.Envelope.Fee() | ||
} | ||
|
||
func FeeCharged(t ingest.LedgerTransaction, l xdr.LedgerCloseMeta) *int64 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tamirms how does passing the LedgerTransaction and LCM through parameters look here?
I will note that for operations we'd need to pass 4 parameters xdr.operation, operationIndex, ingest.LedgerTransaction, xdr.LedgerCloseMeta
Does it make sense to go back to adding these all in a struct instead or params?
…550/xdrill-transactions
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
CHANGELOG.md
within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
github issue
xdrill functions for Transactions
Why
Helper functions for Transactions for processors/transforms from stellar-etl for
history_transactions
found hereKnown limitations