This repository has been archived by the owner on Nov 12, 2024. It is now read-only.
Migrate to kotlin-inject #1105
Merged
Migrate to kotlin-inject #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
force-pushed
the
cb/kotlin-inject
branch
from
f7089ae to
57e5da9
Compare
chrisbanes
force-pushed
the
cb/kotlin-inject
branch
from
57e5da9 to
9bf8f19
Compare
chrisbanes
changed the title
11 tasks
dturner
reviewed
Jun 15, 2023
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| plugins { | |||
| id("kotlin") | |||
| alias(libs.plugins.kotlin.kapt) | |||
| alias(libs.plugins.ksp) | |||
There was a problem hiding this comment.
Did you notice much build time improvement after making this change?
There was a problem hiding this comment.
Maybe? I don't have any numbers to back that up though. There's no more Java being compiled at all, which definitely helps. The goal was to support KMP though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using @evant's https://github.com/evant/kotlin-inject.
SettingsActivitycomponentModuleclasses.Providers (accidentally migrated them toLazy).Fixes #1096