Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to kotlin-inject #68

Merged
merged 60 commits into from
Apr 15, 2023
Merged

Migrate to kotlin-inject #68

merged 60 commits into from
Apr 15, 2023

Conversation

thomaskioko
Copy link
Owner

@thomaskioko thomaskioko commented Apr 13, 2023 •
edited
Loading

Description

This PR migrates from Dagger Hilt and koin to Kotin-inject.

  • Migrate Data modules
  • Migrate Domain modules
  • Refactor Compose navigation module.
  • Migrate Compose screen
  • Resolve iOS platform components
    • Database
    • Datastore
    • Network
    • Tmdb
    • Util
  • Migrate ios from koin to kotlin-inject

Other changes

  • Simplified some of the structure of the shared modules. Core has base and networkutil.
  • Get rid of buildKonfig in the shared module and read API keys from dev.yaml. This only affects iOS. I will migrate the Android implementation in a follow-up PR.
  • Module rename: video-player > trailers, trakt-service > trakt-api
  • Cleanup tooling scripts.

resolves #62

Resources:

thomaskioko added 30 commits April 3, 2023 20:33
@thomaskioko
Add kotlin inject dependency
4aa709f
@thomaskioko
Bump up compose compiler version, add ksp plugin
2c61d99
@thomaskioko
Add ksp plugin
7f17f21
@thomaskioko
Create network module.
481bda3
@thomaskioko
Move network util classes to it's own module.
4469856
@thomaskioko
Rename module from video-player to trailers.
341a1d1
@thomaskioko
Rename module from trakt-service to trakt-api.
a10e4a1
@thomaskioko
Rename modules
dfe66da
@thomaskioko
Delete classes.
a96129f
@thomaskioko
Update class packages.
69036d8
@thomaskioko
Delete koin module classes.
fc0a3fe
@thomaskioko
Rename module from util to base.
6c73254
@thomaskioko
Create util classes.
630f87f
@thomaskioko
Update package name
21cf9ae
@thomaskioko
Rename util module to base
8d32cdf
@thomaskioko
Refactor: Update package name.
65ccd1e
@thomaskioko
Add test annotation util.
2d6f16e
@thomaskioko
Update imports.
7dabc73
@thomaskioko
Migrate to kotlin-inject
100e923
@thomaskioko
Update dependencies: Add network and base modules.
dbb152c
@thomaskioko
Create Android platform component.
c3d74e9
@thomaskioko
Migrate to kotlin-inject annotations.
6bb77aa
@thomaskioko
Move stateMachine wrappers to shared module.
b5f0818
@thomaskioko
Migrate to kotlin-inject
ef26e30
@thomaskioko
Remove network module and rename util to base.
0f33721
@thomaskioko
Rename plugin
5ac93d7
@thomaskioko
Delete unnecessary plugins
8c819e3
@thomaskioko
Remove hilt plugin and replace koin with kotlin-inject.
cd96b6c
@thomaskioko
Refactor trakt implementation and migrate to kotlin-inject
b7189dd
@thomaskioko
Refactor trakt implementation and migrate to kotlin-inject
c6c1512
@thomaskioko thomaskioko added enhancement New feature or request android Android related task/issues ios iOS related task/issue labels Apr 13, 2023
@thomaskioko thomaskioko marked this pull request as ready for review April 15, 2023 01:48
@thomaskioko thomaskioko changed the title [WIP] Migrate to kotlin-inject Migrate to kotlin-inject Apr 15, 2023
@thomaskioko thomaskioko enabled auto-merge April 15, 2023 01:52
@thomaskioko thomaskioko disabled auto-merge April 15, 2023 02:10
@thomaskioko thomaskioko merged commit 6656b51 into main Apr 15, 2023
thomaskioko added a commit that referenced this pull request Nov 1, 2023
@thomaskioko
Merge pull request #68 from c0de-wizard/kotlin-inject
943d150 
Migrate to kotlin-inject
@thomaskioko thomaskioko deleted the kotlin-inject branch November 1, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android Android related task/issues enhancement New feature or request ios iOS related task/issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to kotlin-inject 👀
1 participant
@thomaskioko