Convert Attribution code block to tables #329
Conversation
wopian
added
Status: Review Needed
Type: Meta
README.zh_cn.md
Outdated
| Norman E. Sears | Director, Mission Development<br>Apollo Guidance and Navigation Program | 1969年3月28日 | ||
| Richard H. Battin | Director, Mission Development<br>Apollo Guidance and Navigation Program | 1969年3月28日 | ||
| David G. Hoag | Director<br>Apollo Guidance and Navigation Program | 1969年3月28日 | ||
| Ralph R. Ragan | Deputy Director<br>Instrumentation Laboratory | 1969年3月28日 |
There was a problem hiding this comment.
These fields were already localized in the target language, but they were pasted in English.
|
Awesome work. Infinitely more readable. Lets have a look at @oldmud0 's comment and then we can merge. |
|
Roles did not keep their translations as the text was in all-caps and I don't know the capitalisation rules.
If this is 🆗'd the people who did the original translations can get mentioned to do the modifications correctly |
Added corrections and suggestions from PR #332.
|
|
||
|
|
||
| 제출됨: MARGARET H. HAMILTON 일시: 1969년 3월 28일 | ||
| M.H.HAMILTON, 콜로서스 프로그래밍 리더 |
There was a problem hiding this comment.
We can copy and paste the roles from the original READMEs made by the translators, such as right here. I think "콜로서스 프로그래밍 리더" is the role. Or am I misunderstanding the issue.
There was a problem hiding this comment.
The Korean readme already has the translated roles in this PR
|
@wopian this still good? |
|
Good with me 👍 |
Migrated the attribution section to tables for all languages to aid readability (particularly the approval list) as everything is ALL CAPS.
Unfortunately GFM doesn't allow header-less tables, so it's either an empty header:
or copyright as a header:
Before
After