Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.es.md #332

Closed
wants to merge 1 commit into from
Closed

Update README.es.md #332

wants to merge 1 commit into from

Conversation

TOTON95
Copy link
Contributor

@TOTON95 TOTON95 commented Apr 12, 2018

Few missing letters added, except for this, it was an excellent translation!

Few missing letters added, except for this, it was an excellent translation!
imágenes respectivamente. Muchas gracias a ambos. Las imágenes (con la
consecuente reducción de su tamaño para almacenamiento y de su calidad) están
disponibles en línea en la dirección www.ibiblio.org/apollo. Si por alguna razón
considera que algunas imágenes son ilegibles, contacte comigo en info@sandroid.org
considera que algunas imágenes son ilegibles, contacte conmigo en info@sandroid.org
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that really how it's said? I find it natural to say contáctame por <email> or contactar con <nombre/email>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first option is pretty similar with the correction, and indeed we usually use "contáctame" in our daily speaking, but since I can perceive that certain formality was used (due to "Contacte conmigo"), I suggest to modify the second proposed option to "Contactar a <nombre/email>", What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This question (use 'tú' or 'usted') always arises in the translations projects I've worked in. I prefer the formal approach (usted), but I think is a minor issue.

@TOTON95 thanks

@wopian
Copy link
Collaborator

wopian commented Apr 12, 2018

Can you base these changes on feat/improve-attribution (#329), as the README has been overhauled and requires some additional updates to the translations.

Capitalisation changes:

Missing translations:

  • Part of the source code for Colossus 2A, the Command Module's (CM) Apollo Guidance Computer (AGC) for Apollo 11

  • Part of the source code for Luminary 1A, the Lunar Module's (LM) Apollo Guidance Computer (AGC) for Apollo 11

TOTON95 added a commit to TOTON95/Apollo-11 that referenced this pull request Apr 13, 2018
Added corrections and suggestions from PR chrislgarry#332.
@TOTON95 TOTON95 mentioned this pull request Apr 13, 2018
wopian pushed a commit that referenced this pull request Apr 13, 2018
Added corrections and suggestions from PR #332.
@wopian
Copy link
Collaborator

wopian commented Apr 13, 2018

Merged by #333

@wopian wopian closed this Apr 13, 2018
@wopian wopian added the Type: Meta Translations and other changes outside source code label Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Meta Translations and other changes outside source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants