fix: Move styles into app namespace to avoid ember-cli-sass addon.scss error #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ember-cli-sass plugin has a bug that throws an error about a missing addon.sass file of the plugin when * The host app and one of it's addons both use ember-cli-sass addon and * The host app uses .sass extension and * The plugin uses .scss extension and * The plugin has a addon/styles directory All 4 Conditions are required to reproduce. Best practice amongst ember- cli-sass addon authors became to add stylesheets to the apps namespace and require the developer to import these explicitly into the app's styles. This solution allows both the app and the addon author to use sass with whatever extension they prefer.
ohcibi
changed the title
|
@ohcibi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ember-cli-sass plugin has a bug that throws an error about a missing
addon.sass file of the plugin when
All 4 Conditions are required to reproduce. Best practice amongst ember-
cli-sass addon authors became to add stylesheets to the apps namespace
and require the developer to import these explicitly into the app's
styles. This solution allows both the app and the addon author to use
sass with whatever extension they prefer.