Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on ember-cli-sass and sass #659

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Conversation

bertdeblock
Copy link
Collaborator

  • Uses a pre-commit hook to ensure compiled styles are automatically included in every commit
  • Adds the ability to exclude Ember Freestyle's styles in case people want to define their own styles or if they want to import Ember Freestyle's styles explicitly (when they use ember-cli-sass and want to override variables).

Closes #143, closes #152, closes #172 and closes #537.

Copy link
Collaborator

@lukemelia lukemelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution!

@lukemelia
Copy link
Collaborator

@bertdeblock I think this change requires some action on the part of current users to avoid including the styles twice, correct?

This also adds the ability to exclude Ember Freestyle's styles.
@bertdeblock
Copy link
Collaborator Author

@lukemelia afaict, everything should remain the same for current users. The styles in the app folder won't end up in the app's build unless explicitly imported via @import 'ember-freestyle'. Though, maybe this change is drastic enough to mark it as breaking nonetheless, just to be sure.

@lukemelia lukemelia merged commit bd824ff into master Oct 31, 2021
@lukemelia lukemelia deleted the precompile-styles branch October 31, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing ember-cli-sass dependency Error: File not found: addon.sass
2 participants