Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode error #65

Closed
harlyh opened this issue Jul 16, 2023 · 4 comments
Closed

Unicode error #65

harlyh opened this issue Jul 16, 2023 · 4 comments

Comments

@harlyh
Copy link
Contributor

harlyh commented Jul 16, 2023 •
edited
Loading

The bot starts failing as soon as Unicode is in the recent context window ( such as a smiley, as seen below)
image

I can't really pinpoint if this started happening today because of the latest oobabooga update, or because of the Windows update that I did before ooba update today. Before today I never encountered this issue.

PS! If I remove the "offending" message in Discord, the bot resumes working as normal.
@harlyh
Copy link
Contributor Author

harlyh commented Jul 16, 2023

I already fixed it. Will create a pull request.

@harlyh harlyh closed this as completed Jul 16, 2023
harlyh added a commit to harlyh/oobabot that referenced this issue Jul 16, 2023
@harlyh
Fixed the Unicode logging issue in ooba_client.py
fc3c71e 
Related:
chrisrude#65 (comment)
@harlyh harlyh mentioned this issue Jul 16, 2023
Merged
@chrisrude
Copy link
Owner

Awesome, will take a look in the next few days!

chrisrude pushed a commit that referenced this issue Jul 17, 2023
@harlyh @chrisrude
Fixed the Unicode logging issue in ooba_client.py
12038ff 
Related:
#65 (comment)
@harlyh
Copy link
Contributor Author

harlyh commented Jul 19, 2023

Today, after oobabooga update, log formatting went to hell:
WindowsTerminal_iMtGqTAi06

Created the second fix to account for this kind of thing too, and the result is that under Windows, emojis started showing:
WindowsTerminal_Zp21zzsVaA

@harlyh harlyh reopened this Jul 19, 2023
@harlyh harlyh mentioned this issue Jul 19, 2023
Merged
@chrisrude
Copy link
Owner

Will be included in the next update, closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisrude @harlyh