Unicode logging reliability fix ooba_client.py #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like oobabooga developer was the one who caused this Unicode issue. Refactored the code to enable the "bugfix" only in case it's actually needed. I don't trust developers who do everything on the main branch all the time not repeatedly cause this, so the bugfix is only applied when needed.
chrisrude
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the oobabooga developer was the one who caused this Unicode issue.
Refactored the fix from the last pull request to enable it only when case it's actually needed. I don't trust developers who do everything on the main branch all the time not repeatedly causing this, so the bugfix is only applied when needed.
This commit ensures that this never happens either:
We want to see this:
Obviously, this isn't that bad compared to the situation from 2 days ago when the issue caused bot failures.