Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PullLog Operator should update the next pull offset to be the last record offset + 1 of previous pull #2056

Merged
merged 1 commit into from
May 3, 2024

Conversation

Ishiihara
Copy link
Contributor

@Ishiihara Ishiihara commented Apr 24, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • The PullLogOperator does not correctly update the offset after the first fetch as it might return less records than the batch size.
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@Ishiihara Ishiihara requested a review from HammadB April 24, 2024 23:57
@Ishiihara Ishiihara self-assigned this Apr 24, 2024
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Ishiihara Ishiihara changed the title [BUG] InMemoryLog preserve offset orders [BUG] PullLog Operator should update the next pull offset to be the last record offset + 1 of previous pull Apr 25, 2024
@HammadB
Copy link
Collaborator

HammadB commented Apr 25, 2024

Tests failing

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 6:16pm

@Ishiihara Ishiihara enabled auto-merge (squash) May 3, 2024 20:27
@Ishiihara Ishiihara disabled auto-merge May 3, 2024 20:27
@Ishiihara Ishiihara merged commit e96c545 into chroma-core:main May 3, 2024
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants