Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] PullLog Operator should update the next pull offset to be the last record offset + 1 of previous pull #2056

Merged
merged 1 commit into from
May 3, 2024
Merged

[BUG] PullLog Operator should update the next pull offset to be the last record offset + 1 of previous pull #2056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rust/worker/src/execution/operators/pull_log.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ impl Operator<PullLogsInput, PullLogsOutput> for PullLogsOperator {
}

num_records_read += logs.len();
offset += batch_size as i64;
// unwrap here is safe because we just checked if empty
offset = logs.last().unwrap().log_offset + 1;
Ishiihara marked this conversation as resolved.
Show resolved Hide resolved
result.append(&mut logs);

// We used a a timestamp and we didn't get a full batch, so we have retrieved
Expand Down
Loading