Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Implement GetCollectionWithSegments endpoint for SysDB #3243

Merged
merged 5 commits into from
Dec 17, 2024
Merged

[ENH] Implement GetCollectionWithSegments endpoint for SysDB #3243

merged 5 commits into from
Dec 17, 2024

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Dec 4, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • N/A
  • New functionality
    • Implement the GetCollectionWithSegments interface for SysDB, which should return information about a consistent snapshot for a collection and its segments

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Dec 4, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Sicheng-Pan force-pushed the 12-04-_enh_implement_getcollectionwithsegments_endpoint_for_sysdb branch 2 times, most recently from 8de0623 to f164019 Compare December 5, 2024 00:01
@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review December 5, 2024 00:02
This was referenced Dec 5, 2024
Merged
Merged
sanketkedia
sanketkedia reviewed Dec 6, 2024
View reviewed changes
go/pkg/sysdb/grpc/collection_service.go

res.Collection = convertCollectionToProto(collection)
segmentpbList := make([]*coordinatorpb.Segment, 0, len(segments))
for _, segment := range segments {
Copy link
Contributor

@sanketkedia sanketkedia Dec 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would it make sense to add validation here that a collection will have exactly 3 segments and that too the record, metadata and vector?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some checks for this

@Sicheng-Pan Sicheng-Pan force-pushed the 12-04-_enh_implement_getcollectionwithsegments_endpoint_for_sysdb branch from f164019 to d13f790 Compare December 6, 2024 17:07
@Sicheng-Pan Sicheng-Pan mentioned this pull request Dec 6, 2024
Merged
1 task
@Sicheng-Pan Sicheng-Pan force-pushed the 12-04-_enh_implement_getcollectionwithsegments_endpoint_for_sysdb branch 4 times, most recently from 11e3b2e to 7be4e08 Compare December 11, 2024 20:31
This was referenced Dec 12, 2024
Merged
Merged
@Sicheng-Pan Sicheng-Pan force-pushed the 12-04-_enh_implement_getcollectionwithsegments_endpoint_for_sysdb branch from 7be4e08 to 8d89a3e Compare December 17, 2024 02:09
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Dec 17, 2024 •
edited
Loading

Merge activity

  • Dec 16, 9:44 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 16, 9:44 PM EST: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan merged commit 433cc37 into main Dec 17, 2024
70 of 72 checks passed
@tazarov tazarov mentioned this pull request Dec 19, 2024
Open
@Sicheng-Pan Sicheng-Pan deleted the 12-04-_enh_implement_getcollectionwithsegments_endpoint_for_sysdb branch February 11, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketkedia sanketkedia sanketkedia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sicheng-Pan @sanketkedia