Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable wasmbind feature by default #1472

Merged
merged 1 commit into from
Feb 29, 2024

Commits on Feb 29, 2024

  1. Disable wasmbind feature by default

    This removes `wasmbind` from the default feature set, which stops chrono
    from implicitly depending upon wasm-bindgen and js-sys. This is helpful
    for a few reasons:
    
    * It reduces the default dependency set by default for non-wasm
      projects, which shrinks the download size.
    
    * Projects like Fuchsia have a policy where 3rd party crates need to be
      audited. While we don't use wasm-bindgen, we can't opt out of it by
      setting `default-features = false` because of [feature unification]
      ends up enabling chrono's default feature. See this [cargo issue]
      for more details. `wasm-bindgen` is large and complicated, so it's
      pretty expensive for us to update.
    
    Fixes chronotope#1164
    
    [feature unification]: https://doc.rust-lang.org/cargo/reference/features.html#feature-unification
    [cargo issue]: rust-lang/cargo#4463
    erickt committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    cc4c622 View commit details
    Browse the repository at this point in the history