Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for breakends in VCF #163

Merged
merged 4 commits into from
May 22, 2019
Merged

Add support for breakends in VCF #163

merged 4 commits into from
May 22, 2019

Conversation

alumi
Copy link
Member

@alumi alumi commented May 17, 2019

Summary

This PR adds basic support for breakends in VCF.
Breakends are variant records which have SVTYPE=BND in the INFO field.
They have a dedicated format of string representation for ALT field.
For more details, please refer to the spec "5.4 Specifying complex rearrangements with breakends"

Tests

  • lein check 🆗
  • lein test :all 🆗
  • lein cloverage 🆗

@alumi alumi requested review from athos and r6eve May 17, 2019 08:09
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #163 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #163      +/-   ##
=========================================
+ Coverage   86.02%   86.1%   +0.08%     
=========================================
  Files          71      71              
  Lines        5387    5419      +32     
  Branches      489     489              
=========================================
+ Hits         4634    4666      +32     
  Misses        264     264              
  Partials      489     489
Impacted Files Coverage Δ
src/cljam/io/vcf/util.clj 90.52% <100%> (+1.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ab045...d848699. Read the comment docs.

@alumi alumi force-pushed the feature/breakends branch from 8508f95 to 05543f4 Compare May 20, 2019 04:54
@alumi
Copy link
Member Author

alumi commented May 20, 2019

Resolved conflicts with #162

Copy link
Contributor

@r6eve r6eve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the breakends support.
I'm halfway through my review. I left a comment about regexp.

src/cljam/io/vcf/util.clj Outdated Show resolved Hide resolved
Copy link
Member

@athos athos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this improvement 👍 Basically, it looks good to me.
Added a couple of minor comments.

src/cljam/io/vcf/util.clj Outdated Show resolved Hide resolved
src/cljam/io/vcf/util.clj Show resolved Hide resolved
Copy link
Contributor

@r6eve r6eve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@r6eve r6eve merged commit 7b5d627 into master May 22, 2019
@r6eve r6eve deleted the feature/breakends branch May 22, 2019 08:50
@alumi
Copy link
Member Author

alumi commented May 22, 2019

Thanks!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants