-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for breakends in VCF #163
Conversation
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=========================================
+ Coverage 86.02% 86.1% +0.08%
=========================================
Files 71 71
Lines 5387 5419 +32
Branches 489 489
=========================================
+ Hits 4634 4666 +32
Misses 264 264
Partials 489 489
Continue to review full report at Codecov.
|
Resolved conflicts with #162 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the breakends support.
I'm halfway through my review. I left a comment about regexp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this improvement 👍 Basically, it looks good to me.
Added a couple of minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks!! 🎉 |
Summary
This PR adds basic support for breakends in VCF.
Breakends are variant records which have
SVTYPE=BND
in theINFO
field.They have a dedicated format of string representation for
ALT
field.For more details, please refer to the spec "5.4 Specifying complex rearrangements with breakends"
Tests
lein check
🆗lein test :all
🆗lein cloverage
🆗