Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to inspect an ALT allele of VCF #164

Merged
merged 5 commits into from
May 24, 2019
Merged

Conversation

alumi
Copy link
Member

@alumi alumi commented May 20, 2019

This PR is depending on #163

Summary

This PR adds a function to inspect an ALT allele of a variant in VCF.
The ALT field of VCF is so expressive that it is not so straightforward to know what they mean.
cljam.io.vcf.util/inspect-allele provides a way to classify ALT alleles into 9 10 13 types.
With this feature, we can easily transform VCF variants based on their types. (e.g. filtering only SNPs)

Tests

  • lein check 🆗
  • lein test :all 🆗
  • lein cloverage 🆗

@alumi alumi requested review from athos and r6eve May 20, 2019 03:42
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #164 into master will increase coverage by 0.12%.
The diff coverage is 98.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage    86.1%   86.23%   +0.12%     
==========================================
  Files          71       71              
  Lines        5419     5476      +57     
  Branches      489      490       +1     
==========================================
+ Hits         4666     4722      +56     
  Misses        264      264              
- Partials      489      490       +1
Impacted Files Coverage Δ
src/cljam/io/vcf/util.clj 92.3% <98.24%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5d627...dc63967. Read the comment docs.

@alumi alumi force-pushed the feature/inspect-allele branch 2 times, most recently from 0270bf5 to 1b682cd Compare May 21, 2019 01:03
@alumi alumi force-pushed the feature/inspect-allele branch from 1b682cd to 0f5b1ac Compare May 23, 2019 00:01
@alumi
Copy link
Member Author

alumi commented May 23, 2019

Rebased the branch since #163 is merged

@alumi
Copy link
Member Author

alumi commented May 23, 2019

Sorry. Added a commit 2d1b506 to fix a bug.

Copy link
Contributor

@r6eve r6eve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the useful function. I left some comments.

src/cljam/io/vcf/util.clj Outdated Show resolved Hide resolved
src/cljam/io/vcf/util.clj Outdated Show resolved Hide resolved
Copy link
Member

@athos athos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this enhancement. Looks nice 😃

Copy link
Contributor

@r6eve r6eve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r6eve r6eve merged commit 55353b7 into master May 24, 2019
@r6eve r6eve deleted the feature/inspect-allele branch May 24, 2019 09:55
@alumi
Copy link
Member Author

alumi commented May 24, 2019

Thank you for reviewing! @r6eve @athos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants