-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a function to inspect an ALT allele of VCF #164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 86.1% 86.23% +0.12%
==========================================
Files 71 71
Lines 5419 5476 +57
Branches 489 490 +1
==========================================
+ Hits 4666 4722 +56
Misses 264 264
- Partials 489 490 +1
Continue to review full report at Codecov.
|
0270bf5
to
1b682cd
Compare
1b682cd
to
0f5b1ac
Compare
Rebased the branch since #163 is merged |
Sorry. Added a commit 2d1b506 to fix a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the useful function. I left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this enhancement. Looks nice 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is depending on #163Summary
This PR adds a function to inspect an
ALT
allele of a variant in VCF.The
ALT
field of VCF is so expressive that it is not so straightforward to know what they mean.cljam.io.vcf.util/inspect-allele
provides a way to classifyALT
alleles into91013 types.With this feature, we can easily transform VCF variants based on their types. (e.g. filtering only SNPs)
Tests
lein check
🆗lein test :all
🆗lein cloverage
🆗