Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Layout desktop #629

Merged
merged 2 commits into from
Nov 13, 2018
Merged

[REVIEW] Layout desktop #629

merged 2 commits into from
Nov 13, 2018

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Nov 9, 2018

Descrição

Implementa um novo layout para desktop em que a barra lateral é fixa e há mais de uma conversa por linha na tela de conversas.

Issues Relacionadas

resolves: #557

Checklist

  • Os commits seguem o padrão do projeto (Flake8 e afins)
  • Os testes estão passando e cobrem as mudanças
  • Marcou no título do pull request se ele é work in progress [WIP] ou se está pronto para revisão [REVIEW]

Imagens/Comentários

Vídeo: https://www.youtube.com/watch?v=KRwHRRSmVEc

@caiosba caiosba requested a review from a team November 9, 2018 17:33
@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #629 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #629   +/-   ##
========================================
  Coverage    81.76%   81.76%           
========================================
  Files          123      123           
  Lines         3269     3269           
  Branches       357      357           
========================================
  Hits          2673     2673           
  Misses         491      491           
  Partials       105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178ca8f...286d608. Read the comment docs.

Copy link
Contributor

@pablodiegoss pablodiegoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teste

Testei e parece promissor, ambos layouts funcionando e trocando bem de um pro outro

@pablodiegoss pablodiegoss merged commit 2d15a87 into develop Nov 13, 2018
@delete-merged-branch delete-merged-branch bot deleted the i557_desktop_layout branch November 13, 2018 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementar página desktop do EJ
2 participants