Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapters are off by 1 Page if "De-dupe cover" is enabled #742

Closed
bust4cap opened this issue Sep 9, 2024 · 0 comments · Fixed by #772 · May be fixed by #743
Closed

Chapters are off by 1 Page if "De-dupe cover" is enabled #742

bust4cap opened this issue Sep 9, 2024 · 0 comments · Fixed by #772 · May be fixed by #743

Comments

@bust4cap
Copy link

bust4cap commented Sep 9, 2024

Describe the bug
When De-dupe cover is enabled and a cbz with chapter info is being converted, the resulting epub has wrong chapter information. For example if page 6 is supposed to have a chapter, in the converted epub its page 7 instead, and therefore starts one page late.

To Reproduce

  1. add a cbz with chapters inside a comicinfo.xml file
  2. enable De-dupe cover
  3. set output to EPUB
  4. click convert

Expected behavior
I expected the chapters to be on the correct page, not one page late :P

Screenshots
kcc_settings

Desktop (please complete the following information):

  • OS: Windows 11
  • Device: not applicable

Additional context
This also causes a "list index out of range" error when a chapter is the very last page

@bust4cap bust4cap changed the title Chapters are off by 1 Page if "De-duper cover" is enabled Chapters are off by 1 Page if "De-dupe cover" is enabled Sep 9, 2024
@axu2 axu2 closed this as completed in #772 Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant