-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt at fixing "de-dupe cover" breaking chapters #743
base: master
Are you sure you want to change the base?
Conversation
- fixed de-dupe cover breaking chapters
- getting correct uniqueid for cover instead of (wrongly) assuming it
Wouldn't it be simpler to just add a offset of 1 on this line if the option is checked? https://github.com/ciromattia/kcc/blob/master/kindlecomicconverter/comic2ebook.py#L534 |
maybe i did something wrong but doing it that way if the first page is a chapter (aka "cover" for example) its instead just a copy of the last chapter again |
Oh that's because the -1 index is the last item of a list in python. e.g. long_list = [1,2,3]
print(long_list[-1]) prints 3 So some additional logic to skip the first chapter if its only one page. Or clamp the index to zero if multiple pages. |
someone more capable than me should probably take this over if another approach is preferred^^ |
Went ahead and opened a PR please review and test. |
should fix #742
(also fixing general page spread alignment)