Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bookmark drift when dedupecover is checked #772

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

axu2
Copy link
Collaborator

@axu2 axu2 commented Nov 10, 2024

@axu2 axu2 changed the title remove cover chapter as needed remove cover chapter when dedupecover is checked Nov 10, 2024
@axu2 axu2 changed the title remove cover chapter when dedupecover is checked fix chapter alignment when dedupecover is checked Nov 10, 2024
@axu2 axu2 changed the title fix chapter alignment when dedupecover is checked fix bookmark drift when dedupecover is checked Nov 11, 2024
@bust4cap
Copy link

bust4cap commented Nov 11, 2024

doing it this way places the "cover" chapter on the first page after the cover.
if that page also has a chapter, it replaces the cover one.
(but it technically fixes the underlying issue of the (other) chapters being one page off)

@axu2 axu2 merged commit 4e6ee8b into ciromattia:master Nov 11, 2024
@axu2 axu2 deleted the cover-chapter branch November 11, 2024 16:19
@axu2
Copy link
Collaborator Author

axu2 commented Nov 11, 2024

OK, I see the behavior difference now, but I'll have to look into it further at another time.

for now, I greatly simplified the code to just skip the first bookmark if option is checked, and -1 from all the later ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chapters are off by 1 Page if "De-dupe cover" is enabled
2 participants