261 UI: Update All Domains & All Vulnerabilities Tables #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Built new table with MUI DataGrid - Built new fetchAllDomains callBack function in useDomainApi.ts - Pagination, filtering, and sorting are client side now.
- Removed the query paramters as they are not needed.
…domainsall-vulnerabilities-tables
- made PAGE_SIZE consistent accross all tables. It defaults to 15 rows now. - replaced react table with material-ui table - added custom sort for severity levels - server side pagination and filtering for Domains and Vulnerabilities tables - removed old code for react-table in Domains
- Added a status change dropdown to the vulnerabilities table - Added a return if domains or vulnerabilities are empty upon filtering. Prevents the table from rendering empty if there are no domains or vulnerabilities matching the filter
- Removed old React Table code - Removed any unused code - Added hyperlink for the domain name - Added endIcons to Vulnerability, Domain, and Status columns - Added domianId to row data object
1 task
- Removed unused import for set in from Domains.tsx - Removed unused import for sub from Vulnerabilities.tsx - Removed unused initialSortBy function in Vulnerabilities.tsx - Removed unused initialFilterBy function in Vulnerabilities.tsx
hawkishpolicy
requested review from
aloftus23,
cduhn17,
Matthew-Grayson,
nickviola,
rapidray12 and
schmelz21
as code owners
chrtorres
approved these changes
May 24, 2024
- Created a new interface for the TestVulnerability object.
…domainsall-vulnerabilities-tables
- Removed console.logs from Domains.tsx and Vulnerabilities.tsx
schmelz21
requested changes
Jun 6, 2024
|
I was under the impression that button took you to the domain in question. |
@hawkishpolicy - after our review, yes let's keep it in this code push as it is exsiting functionality. We can make an Issue to review at a later time. Thanks. Approving this PR. |
schmelz21
approved these changes
Jun 6, 2024
- Added aria-labels to icons with no text in Domains and Vulnerabilities tables - Removed tab indexes from icons in Domains and Vulnerabilities tables so as not to interfere with tabbing through the table -
…domainsall-vulnerabilities-tables
…domainsall-vulnerabilities-tables
rapidray12
approved these changes
Jun 14, 2024
schmelz21
deleted the
261-ui-update-all-domainsall-vulnerabilities-tables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace old React Table based tables with the new MUI Data Grid X tables
🗣 Description
💭 Motivation and context
🧪 Testing
📷 Screenshots (if appropriate)
Uncomment this section if a screenshot is needed.
✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist