-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add cisagov/ansible-role-amazon-ssm-agent #115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
bug
This issue or pull request addresses broken functionality
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
version bump
This issue or pull request increments the version number
packer
Pull requests that update Packer code
labels
Sep 13, 2024
This is necessary because the community.general collection is listed as a dependency in src/requirements.yml.
The role supports the installation of amazon-ssm-agent via snap on Ubuntu with the merging of cisagov/ansible-role-amazon-ssm-agent#57.
…sm-agent This is being done for testing purposes and this change can be reverted once cisagov/ansible-role-amazon-ssm-agent#57 is merged.
jsf9k
force-pushed
the
improvement/use-amazon-ssm-agent-role
branch
from
September 13, 2024 17:48
c091676
to
b6792bf
Compare
…-agent We can do this now that cisagov/ansible-role-amazon-ssm-agent#57 has been merged.
dv4harr10
approved these changes
Sep 16, 2024
dav3r
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue or pull request addresses broken functionality
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
packer
Pull requests that update Packer code
version bump
This issue or pull request increments the version number
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the code to re-add the cisagov/ansible-role-amazon-ssm-agent Ansible role.
💭 Motivation and context
This role was failing on Ubuntu systems (see cisagov/ansible-role-amazon-ssm-agent#56) but no longer thanks to cisagov/ansible-role-amazon-ssm-agent#57.
🧪 Testing
I successfully built a staging AMI with these changes and verified that it functions as expected.
✅ Pre-approval checklist
✅ Pre-merge checklist
snap
on Ubuntu ansible-role-amazon-ssm-agent#57 is merged.✅ Post-merge checklist