Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install via snap on Ubuntu #57

Merged
merged 5 commits into from
Sep 14, 2024
Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jul 10, 2024

🗣 Description

This pull request modifies the Ansible role to install the Amazon SSM agent via snap on Ubuntu.

💭 Motivation and context

Resolves #56.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

According to the documentation from AWS, the SSM Agent should be
installed via snap on all Ubuntu versions that we support:
https://docs.aws.amazon.com/systems-manager/latest/userguide/agent-install-ubuntu-64-snap.html
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality breaking change This issue or pull request involves changes to existing functionality labels Jul 10, 2024
@jsf9k jsf9k self-assigned this Jul 10, 2024
…untu

This is because on Ubuntu the service is installed via snap.
We have to let the snapd service initialize and we have to start the
snapd socket before we can attempt to install anything via snap.
Additionally, the snap install command tends to fail the first time we
run it when testing via Molecule so we have to re-run the command
until it succeeds.  (Usually only a second run is necessary.)
Also add some snap-specific tests for Ubuntu.
@jsf9k jsf9k force-pushed the bugfix/install-via-snap-on-ubuntu branch from d8a1aa5 to e0ad88d Compare September 13, 2024 14:07
@jsf9k jsf9k marked this pull request as ready for review September 13, 2024 15:19
@jsf9k jsf9k requested a review from a team September 13, 2024 15:19
jsf9k added a commit to cisagov/nessus-packer that referenced this pull request Sep 13, 2024
The role supports the installation of amazon-ssm-agent via snap on
Ubuntu with the merging of cisagov/ansible-role-amazon-ssm-agent#57.
jsf9k added a commit to cisagov/nessus-packer that referenced this pull request Sep 13, 2024
…sm-agent

This is being done for testing purposes and this change can be
reverted once cisagov/ansible-role-amazon-ssm-agent#57 is merged.
jsf9k added a commit to cisagov/openvpn-packer that referenced this pull request Sep 13, 2024
The role supports the installation of amazon-ssm-agent via snap on
Ubuntu with the merging of cisagov/ansible-role-amazon-ssm-agent#57.
jsf9k added a commit to cisagov/openvpn-packer that referenced this pull request Sep 13, 2024
…sm-agent

This is being done for testing purposes and this change can be
reverted once cisagov/ansible-role-amazon-ssm-agent#57 is merged.
jsf9k added a commit to cisagov/ubuntu-server-packer that referenced this pull request Sep 13, 2024
The role supports the installation of amazon-ssm-agent via snap on
Ubuntu with the merging of cisagov/ansible-role-amazon-ssm-agent#57.
jsf9k added a commit to cisagov/ubuntu-server-packer that referenced this pull request Sep 13, 2024
…sm-agent

This is being done for testing purposes and this change can be
reverted once cisagov/ansible-role-amazon-ssm-agent#57 is merged.
jsf9k added a commit to cisagov/openvpn-packer that referenced this pull request Sep 13, 2024
The role supports the installation of amazon-ssm-agent via snap on
Ubuntu with the merging of cisagov/ansible-role-amazon-ssm-agent#57.
jsf9k added a commit to cisagov/openvpn-packer that referenced this pull request Sep 13, 2024
…sm-agent

This is being done for testing purposes and this change can be
reverted once cisagov/ansible-role-amazon-ssm-agent#57 is merged.
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snap to the future 🚀

@jsf9k jsf9k merged commit 0503968 into develop Sep 14, 2024
53 checks passed
@jsf9k jsf9k deleted the bugfix/install-via-snap-on-ubuntu branch September 14, 2024 13:47
jsf9k added a commit to cisagov/ubuntu-server-packer that referenced this pull request Sep 14, 2024
jsf9k added a commit to cisagov/openvpn-packer that referenced this pull request Sep 14, 2024
jsf9k added a commit to cisagov/nessus-packer that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This issue or pull request involves changes to existing functionality bug This issue or pull request addresses broken functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Role fails when applied to an Ubuntu AMI
3 participants