Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add cisagov/ansible-role-amazon-ssm-agent #29

Merged
merged 6 commits into from
Sep 14, 2024
Merged

Re-add cisagov/ansible-role-amazon-ssm-agent #29

merged 6 commits into from
Sep 14, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Sep 13, 2024 •
edited
Loading

🗣 Description

This pull request updates the code to re-add the cisagov/ansible-role-amazon-ssm-agent Ansible role.

💭 Motivation and context

This role was failing on Ubuntu systems (see cisagov/ansible-role-amazon-ssm-agent#56) but no longer thanks to cisagov/ansible-role-amazon-ssm-agent#57.

🧪 Testing

I successfully built a staging AMI with these changes and verified that it functions as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

✅ Post-merge checklist

  • Create a release.

@jsf9k
Bump version from 1.5.0 to 1.5.1
cd59cb5
@jsf9k
Bump version from 1.5.1 to 1.5.1-rc.1
858c55c
@jsf9k
Add back in cisagov/ansible-role-amazon-ssm-agent
5003998 
The role supports the installation of amazon-ssm-agent via snap on
Ubuntu with the merging of cisagov/ansible-role-amazon-ssm-agent#57.
@jsf9k
Temporarily use a non-default branch of cisagov/ansible-role-amazon-s…
c8e15c4 
…sm-agent

This is being done for testing purposes and this change can be
reverted once cisagov/ansible-role-amazon-ssm-agent#57 is merged.
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number packer Pull requests that update Packer code labels Sep 13, 2024
@jsf9k jsf9k self-assigned this Sep 13, 2024
@jsf9k jsf9k marked this pull request as ready for review September 13, 2024 18:00
@jsf9k jsf9k requested a review from a team September 13, 2024 18:01
dav3r
dav3r approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k enabled auto-merge September 14, 2024 21:03
@jsf9k jsf9k merged commit 9be1b6a into develop Sep 14, 2024
10 checks passed
@jsf9k jsf9k deleted the improvement/use-amazon-ssm-agent-role branch September 14, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

Labels
bug This issue or pull request addresses broken functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use packer Pull requests that update Packer code version bump This issue or pull request increments the version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @dv4harr10